jheaps
de4331de72
Every input and select a dealer touches has a rule asking for min-height: 44px, and not one of them was 44px tall. Form controls are content-box by default, so 44 was being read as the height of the text inside, and 8px of padding top and bottom plus a 1px border each side went on the outside of it. Measured on an iPhone: all fifteen settings fields in the sidebar stood at 62px, and the raise pad's amount box at 66 with the text turned up. Nothing looked wrong, which is why it lasted. 62px clears a 44px floor, so the sweep — which asks whether a target is big enough, never whether it is the size it was asked to be — had nothing to say, and one field is not obviously too tall. The cost is only visible in the aggregate: Table Setup 941px to 869, the waiting list 212 to 194, every panel in the sidebar open 2,993 to 2,813. The raise pad's field was worth measuring rather than assuming, because it is not only a field: it sets the action bar's height, the bar's height is published into --feltRoomPx, and the felt is laid out from what is left. It takes 10px off the bar and hands them to the table. On a Galaxy S8 twelve-handed at 20px text the bar goes 248px to 238 and seat 7's stack comes out from behind it — with the taller field the sweep reported "$1,100 is 7/7 under div#actionBar", a figure a dealer cannot read at all. Written against the element types rather than the surfaces they sit on. The surface version was written first and had already missed the waiting list's name box, two hundred lines from anything it named. This is the third time this stylesheet has been caught by content-box; the panel headers and the rulings summaries are the other two. The new test holds every field given a 44px floor to being measured the way that floor assumes. 1167 tests, 418 audits clean.