jheapsandClaude Opus 5
2f6d63400a
Last round I found a regression I'd shipped two rounds earlier: the standings table's player-name column was zero pixels wide, at every viewport, and nobody noticed because the audit that would have caught it only ever existed in a previous session's scrollback. These checks have been re-written by hand at least six times, and each time they covered only whatever had just changed. So they're a file now. uiAudit.js runs in the page — no build step, no package.json, no dependency — and checks touch-action and tap highlights, that fields stay selectable and are big enough not to trigger iOS zoom, that nothing important is covered or stranded off-screen, that no grid column has collapsed to nothing, and that no text is painted outside its box. runUiAudit.js drives it over the table, all five overlays and Quick Split at thirteen viewports. Deliberately outside CI: the unit suite is dependency-free and runs in a second, this one needs a browser and a running site. Three real faults it found on its first run Fields were 13.3px on every iPad. The 16px minimum that stops iOS zooming the page on focus went in inside a max-width:700px block, and every iPad is wider than that — so a dealer on a tablet, which is the device this is most likely to be propped up on, got the table zoomed every time they touched the blind amount. The reason for that rule was never "narrow screen", it was "iOS". Font size applies at all widths now, and the 44px touch targets key off hover:none, which is what actually distinguishes a finger from a mouse. The seat menu couldn't be scrolled. It had no height limit and no overflow, so on a phone held sideways its first two actions — Fold and All-in — sat below the bottom of the screen with no way to reach them. A dealer in landscape could long-press a seat and then not fold it. The pot wizard sat under the action bar. Every other overlay is z-index 90-98; the wizard alone was at 50, below both the action bar at 55 and the toast at 80. In landscape one of its inputs was completely covered by the Fold button, and a toast could sit over "Confirm Winner(s)". It was the odd one out rather than a decision. Three faults in the audit itself, found by checking before acting Worth recording, because each would have had me "fix" something that wasn't broken: - an ellipsised name was reported as painting outside its seat. A Range measures laid-out text, which runs past the element while overflow:hidden quietly clips it. Only overflow that is actually visible can paint over a neighbour. - every link below the fold was reported as off-screen. Something under the fold on a page that scrolls is reachable; the check now asks whether scrolling can bring it into view, which is the thing that actually matters. - a button in the newly-scrollable seat menu came back "covered by null". elementFromPoint returns null for a point outside a scrollable ancestor's clip — scrolled out of view, not covered by anything. A toast partly over a control is a warning rather than a failure now: it dismisses itself and carries a close button, and on a desktop it necessarily lands over a table that fills the content column. Fully covered by a toast is still a failure, because that was a real bug once — a seat sat exactly under the Undo button. Final sweep: 13 viewports, 65 overlay checks, 13 full-page audits, 4 Quick Split audits, zero failures, one warning. 137 unit tests still passing. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb
70 lines
3.2 KiB
Markdown
70 lines
3.2 KiB
Markdown
# Hold'em dealer tests
|
|
|
|
Unit tests for the money logic behind `/Casino/TexasHoldem` — the betting engine, the
|
|
side-pot calculator, the split calculator and the table state.
|
|
|
|
```bash
|
|
node --test tests/holdem/*.test.js
|
|
```
|
|
|
|
No install step, no `package.json`, no dependencies. The browser modules are plain
|
|
script-tag files that each end with a `module.exports` guard, so Node can require them
|
|
as-is; `load.js` puts them on `globalThis` under the same names they use to find each
|
|
other in the page, in the load order from `TexasHoldem.cshtml`.
|
|
|
|
## What's covered
|
|
|
|
| File | Covers |
|
|
| --- | --- |
|
|
| `potCalculator.test.js` | Main and side pots, dead money, uncalled bets, odd-cent distribution |
|
|
| `betting.test.js` | Blinds, street completion, raises reopening the action, all-in run-outs |
|
|
| `state.test.js` | Button rotation, which seats post blinds, session standings |
|
|
| `splitCalculator.test.js` | Chopped pots, odd chips, unmakeable denominations |
|
|
| `invariants.test.js` | 1000 randomised hands per property (see below) |
|
|
|
|
## The layout audit
|
|
|
|
The unit tests above cover the money. `uiAudit.js` covers the thing you can only see
|
|
in a browser: whether a dealer can actually reach every control.
|
|
|
|
```bash
|
|
node tests/holdem/runUiAudit.js # needs Playwright and the site running
|
|
```
|
|
|
|
It checks touch-action and tap highlights, that fields stay selectable and are large
|
|
enough not to trigger iOS zoom, that nothing important is covered or off-screen with
|
|
no way to scroll to it, that no grid column has collapsed to nothing, and that no
|
|
text is painted outside its box. It runs over the table, all five overlays and Quick
|
|
Split, at thirteen viewports from a 360px phone to a 1600px desktop and the same
|
|
phones on their side.
|
|
|
|
Deliberately not in CI: the unit suite is dependency-free and runs in a second, while
|
|
this one needs a browser and a running site. Run it after any change that adds or
|
|
resizes a control. With no Playwright to hand, paste `uiAudit.js` into devtools and
|
|
call `LayoutAudit.runAll()`.
|
|
|
|
It exists because these checks were being re-typed into a console every time
|
|
something changed, and each time they only covered whatever had just been touched.
|
|
That is how the standings table shipped with a player-name column zero pixels wide
|
|
and kept it for two rounds.
|
|
|
|
## Why the randomised suite exists
|
|
|
|
Every correctness bug found in this tool so far has been shape-dependent: blinds posted
|
|
to empty chairs, the button skipping past players, heads-up acting out of order, an
|
|
overbet announced as a side pot. None of them show up on a full six-handed table with
|
|
equal stacks, which is the table anyone writes a fixed example for.
|
|
|
|
`invariants.test.js` deals a thousand hands across random seat counts, random empty
|
|
chairs, random stack depths and random dealer input, and checks the things a dealer
|
|
would notice being wrong:
|
|
|
|
- chips are never created or destroyed during play
|
|
- the pot breakdown plus the uncalled returns always equal the money that went in
|
|
- paying the pot out settles it to the cent
|
|
- once uncalled chips are handed back, nobody is still betting above the whole table
|
|
- the button and both blinds always land on players who are actually in the hand
|
|
|
|
The generator is seeded, so a failure reproduces from the seed printed in the message
|
|
rather than being a flake to re-run.
|