jheapsandClaude Opus 5
2a080eab6a
The chips were the last thing on the table nobody had measured, and the sweep had never seen one: it audited a table that had never had a bet placed on it, so a third of what is on the felt during a hand went unlooked at for the tool's whole life. It posts blinds, deals and calls three times now before it measures anything. What that found, and what this fixes: - Chips accumulated. Seats are kept and updated in place rather than rebuilt, so clearing the bets layer stopped clearing the ones anchored inside a seat and nothing else ever did. An iPhone 14 had one chip per seat after the deal and five by the third render; a dealer's every tap left another disc on the felt. - The ring-or-cling decision asked how wide the window was. A phone held sideways is 844px across and gives the felt 117px: it passed the width test, took the ring, and every chip on it was painted under a puck — the seats carry z-index 1 and the bets layer carries none, so a chip that lands under one is gone, and with it the only number saying what that player has in. Measured now, and only measured. - Getting clear of a box was `edgeReach(puck) + edgeReach(chip)`, which is right only straight up, down or sideways. Two axis-aligned boxes are clear when they are apart on one axis, so the travel is the reach of the box you get by adding their widths and their heights. At 768x1024 a $10 leaving a seat on the diagonal wanted 88px and got 77, and came to rest 11px inside its own player's puck — every seat off the four compass points, which is most of them. - Every chip was laid out at the first chip's size. A chip is as wide as the number on it: "$5" is 21px and "$10" is 27px on a phone, so each $10 was placed as if it were 6px narrower than it is. The widest is no better: at 768x1024 one 47px chip made the whole table give up a ring the other four had room for. - Anchored chips settled where they landed. At 640x360 the felt is 528x83 and a puck is 55 of those pixels tall: clearing it takes 41px, the players facing each other are 70px apart, and both chips set off 41px into a gap that is 70 wide. Three overlapping pairs on a twelve-handed table. Each chip now gives ground only to something it is actually standing on, a pixel at a time — a midline rule or a single scale factor both punish the seats at the ends of a rail, which were never going to hit anything. - Nothing knew the pot total was there. Seat 1's $10 was sitting on "Pot $65". Two things off the felt, from the same sweep: - The toast outlived its news. "Next hand — button on seat 2. [Undo]" stayed up while the hand was dealt and three players called: an offer to move the button, wired to a snapshot that predates the hand, so taking it would have thrown the hand away without saying so. It was also in the way of thirty small screens' seats and controls. The bar drops it as it takes the next action; the bar's own Undo names what it would actually take back. - The pot dialog cut a name off. Three players in the pot on a Galaxy S8, two rows visible, the third below a hairline that reads as the end of the list — a dealer ticking the two they could see would have paid two thirds of a three-way pot. The 85vh budget was still subtracting the action bar's height from a dialog that has sat above the bar since its z-index was fixed, and a player's ceiling moves beside their name on a short screen. All three fit now, and where a list does run on, it runs on under a fade rather than stopping dead on a row boundary. The pot badge goes on a phone held sideways: 86x66 of a 692x113 felt, for a number the action bar prints three inches below it, standing in the only band a bet chip has. The audit stopped calling one thing another. An element clipped away by a panel that scrolls is not covered by whatever is painted at that height — the wizard's third winner came back for four viewports as "fully covered by button Confirm Winner(s)". 190 audits: 25 failing configurations to 7, and every one of those seven is the seat ring hanging past the rail on a landscape phone, which is the known residual from the last round. 663 unit tests, 44 of them new. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb
117 lines
6.5 KiB
Markdown
117 lines
6.5 KiB
Markdown
# Hold'em dealer tests
|
|
|
|
Unit tests for the money logic behind `/Casino/TexasHoldem` — the betting engine, the
|
|
side-pot calculator, the split calculator and the table state.
|
|
|
|
```bash
|
|
node --test tests/holdem/*.test.js
|
|
```
|
|
|
|
No install step, no `package.json`, no dependencies. The browser modules are plain
|
|
script-tag files that each end with a `module.exports` guard, so Node can require them
|
|
as-is; `load.js` puts them on `globalThis` under the same names they use to find each
|
|
other in the page, in the load order from `TexasHoldem.cshtml`.
|
|
|
|
## What's covered
|
|
|
|
| File | Covers |
|
|
| --- | --- |
|
|
| `potCalculator.test.js` | Main and side pots, dead money, uncalled bets, odd-cent distribution |
|
|
| `betting.test.js` | Blinds, street completion, raises reopening the action, all-in run-outs |
|
|
| `state.test.js` | Button rotation, which seats post blinds, session standings |
|
|
| `splitCalculator.test.js` | Chopped pots, odd chips, unmakeable denominations |
|
|
| `invariants.test.js` | 1000 randomised hands per property (see below) |
|
|
|
|
## The layout audit
|
|
|
|
The unit tests above cover the money. `uiAudit.js` covers the thing you can only see
|
|
in a browser: whether a dealer can actually reach every control.
|
|
|
|
```bash
|
|
node tests/holdem/runUiAudit.js # needs Playwright and the site running
|
|
```
|
|
|
|
It checks WCAG AA contrast, touch target sizes, touch-action and tap highlights, that fields stay selectable and are large
|
|
enough not to trigger iOS zoom, that nothing important is covered or off-screen with
|
|
no way to scroll to it, that no grid column has collapsed to nothing, that no
|
|
text is painted outside its box, that no seat covers another seat's writing, and that
|
|
no bet chip is hidden behind a seat or another chip. It
|
|
runs over the table, all five overlays and Quick Split, at thirteen viewports from a
|
|
360px phone to a 1600px desktop and the same phones on their side — each viewport
|
|
twice, once with a mouse and once with a thumb, and at two table shapes, mid-hand:
|
|
the sweep posts blinds, deals and calls three times before it measures anything, so
|
|
the bets layer has chips on it. It used to audit a table nobody had ever bet at,
|
|
which is a third of what is on the felt during a hand left unlooked at.
|
|
|
|
"Covered" and "out of view" are told apart before anything is hit-tested. An element
|
|
clipped away by a panel that scrolls is not covered by whatever happens to be painted
|
|
at that height, and reporting it that way is a diagnosis of something that isn't
|
|
happening: the pot wizard's third winner, below the fold in a list, came back for four
|
|
viewports running as "fully covered by button Confirm Winner(s)".
|
|
|
|
Two table shapes is also newer than it sounds. The sweep ran on one — five players at
|
|
a nine-handed table — for its whole life, and how much room the felt has depends on
|
|
how many people are sitting down far more than on anything a viewport can report. A
|
|
full table is where the seats crowd and it had never been looked at: the first sweep
|
|
that did found one player's name or stack painted under another on eighteen of the
|
|
configurations, on every phone in the list.
|
|
|
|
That last part, and two of those checks, are newer than this paragraph claiming them.
|
|
`runAll()` did not include the contrast check at all, and touch targets sat behind an
|
|
opt-in flag nothing passed, so "the audit is clean" meant nine checks rather than
|
|
eleven for a long run of rounds. Both were written and tested and simply never called.
|
|
The mouse/thumb pair matters for the same reason: the 44px rule stands itself down
|
|
where `hover: hover` says there is a pointer, and a headless desktop browser is a
|
|
pointer, so a single pass had never measured a touch target at any viewport. Between
|
|
them they found a 9px seat label at 3.39:1, a 37px-tall amount field and a 30px delete
|
|
button on Quick Split.
|
|
|
|
A check that decides it doesn't apply says so in the output rather than reporting no
|
|
offenders, which reads identically to a pass. The same goes for the two exemptions
|
|
that exist: a disabled control, which WCAG itself excuses, and a link inside a
|
|
sentence, whose size is set by the line it sits in.
|
|
|
|
Deliberately not in CI: the unit suite is dependency-free and runs in a second, while
|
|
this one needs a browser and a running site. Run it after any change that adds or
|
|
resizes a control. With no Playwright to hand, paste `uiAudit.js` into devtools and
|
|
call `LayoutAudit.runAll()`.
|
|
|
|
The contrast check is built so it cannot report a false positive: backgrounds
|
|
composite through alpha, and where a gradient is involved every colour stop is tried
|
|
and the most flattering one used. A finding means the text fails even under the
|
|
reading most generous to it. Two earlier attempts at this got it wrong in both
|
|
directions — one read only `background-color` and scored text on a gradient against
|
|
nothing, the other treated low-alpha stops as opaque — so `uiAudit.js` is checked
|
|
against known-answer cases before it is believed.
|
|
|
|
Touch targets are measured by probing outward with `elementFromPoint` rather than by
|
|
reading the element box, because the box lies in both directions: a small control can
|
|
be padded out with a transparent `::after` and respond well beyond its painted size,
|
|
and a checkbox inside a label is hit by tapping the label. The 44px rule is only
|
|
enforced where `hover: none` says there's no mouse.
|
|
|
|
It exists because these checks were being re-typed into a console every time
|
|
something changed, and each time they only covered whatever had just been touched.
|
|
That is how the standings table shipped with a player-name column zero pixels wide
|
|
and kept it for two rounds.
|
|
|
|
## Why the randomised suite exists
|
|
|
|
Every correctness bug found in this tool so far has been shape-dependent: blinds posted
|
|
to empty chairs, the button skipping past players, heads-up acting out of order, an
|
|
overbet announced as a side pot. None of them show up on a full six-handed table with
|
|
equal stacks, which is the table anyone writes a fixed example for.
|
|
|
|
`invariants.test.js` deals a thousand hands across random seat counts, random empty
|
|
chairs, random stack depths and random dealer input, and checks the things a dealer
|
|
would notice being wrong:
|
|
|
|
- chips are never created or destroyed during play
|
|
- the pot breakdown plus the uncalled returns always equal the money that went in
|
|
- paying the pot out settles it to the cent
|
|
- once uncalled chips are handed back, nobody is still betting above the whole table
|
|
- the button and both blinds always land on players who are actually in the hand
|
|
|
|
The generator is seeded, so a failure reproduces from the seed printed in the message
|
|
rather than being a flake to re-run.
|