Make the seats that are out of the hand readable again #81
Closed
jheaps
wants to merge 1 commits from
fix/casino-holdem-readable-dim-states into fix/casino-holdem-drop-broken-watermark
pull from: fix/casino-holdem-readable-dim-states
merge into: :fix/casino-holdem-drop-broken-watermark
:master
:feature/socialism
:polish/holdem-seats-one-size
:fix/holdem-dealer-chip-eats-its-seat
:polish/holdem-game-night-ready
:polish/holdem-round-next
:polish/holdem-seat-collisions
:polish/holdem-offline-and-render
:fix/naming-a-blind-deals-the-hand
:release/casino-holdem-polish
:fix/casino-holdem-phone-look
:fix/casino-holdem-sidebar-crowding
:fix/casino-holdem-contribution-rule
:fix/casino-holdem-one-stack-rule
:fix/casino-holdem-default-stack-buyin
:feat/casino-holdem-waiting-list
:feat/casino-holdem-misdeal
:feat/casino-holdem-cash-out
:feat/casino-holdem-clock
:feat/casino-holdem-rake
:fix/casino-holdem-stadium-ring
:fix/casino-holdem-phone-felt-shape
:fix/casino-holdem-audit-runs-everything
:feat/casino-holdem-straddle
:fix/casino-holdem-landscape-ring
:feat/casino-holdem-table-file
:fix/casino-holdem-touch-targets
:fix/casino-holdem-audit-modal-blindspot
:fix/casino-holdem-quicksplit-chop
:fix/casino-holdem-buildable-bet-sizes
:fix/casino-holdem-pot-sized-raise
:fix/casino-holdem-chips-to-count-out
:fix/casino-holdem-first-buy-in
:fix/casino-holdem-seating-a-table
:fix/casino-holdem-showdown-order
:fix/casino-holdem-hand-log-filter
:fix/casino-holdem-posting-in
:fix/casino-holdem-dead-button
:fix/casino-holdem-discarded-pot
:fix/casino-holdem-honest-tank-clock
:fix/casino-holdem-export-the-notes
:fix/casino-holdem-stacks-in-chips
:fix/casino-holdem-close-audit-blind-spots
:fix/casino-holdem-readable-dim-states
:fix/casino-holdem-drop-broken-watermark
:fix/casino-holdem-two-tabs
:fix/casino-holdem-unreadable-save
:fix/casino-holdem-say-when-not-saving
:fix/casino-holdem-shortcut-discovery
:fix/casino-holdem-rulings-index-compact
:fix/casino-holdem-rulings-index
:fix/casino-holdem-payout-in-chips
:fix/casino-holdem-move-seat-on-touch
:fix/casino-holdem-amount-fields-select
:fix/casino-holdem-touch-targets-by-pointer
:fix/casino-holdem-button-box-model
:fix/casino-holdem-blind-badge-placement
:fix/casino-holdem-buyin-deals-in
:fix/casino-holdem-bet-vs-raise
:fix/casino-holdem-deal-around-broke
:fix/casino-holdem-settle-up
:fix/casino-holdem-allin-and-bar
:fix/casino-holdem-one-dealer-button
:fix/casino-holdem-manual-deal
:fix/casino-holdem-less-guessing
:feature/casino-holdem-seat-editor
:fix/casino-holdem-landscape-table
:feature/casino-holdem-acting-seat
:feature/casino-holdem-raise-guard
:feature/casino-holdem-first-run
:feature/casino-holdem-contrast-audit
:feature/casino-holdem-layout-audit
:feature/casino-holdem-blind-fairness
:feature/casino-holdem-rulings-depth
:feature/casino-holdem-bank-audit
:feature/casino-holdem-fewer-taps
:feature/casino-holdem-render-perf
:feature/casino-holdem-keyboard-focus
:feature/casino-holdem-resilience
:feature/casino-holdem-messy-tables
:feature/casino-holdem-touch-mobile
:chore/casino-holdem-tech-debt
:feature/casino-holdem-dealer-batch
:feature/casino-holdem-seat-count-safety
:feature/casino-holdem-odd-chip
:feature/casino-holdem-button-moves
:feature/casino-holdem-allin-runout
:feature/casino-holdem-heads-up
:feature/casino-holdem-contrast
:feature/casino-holdem-touch-audit
:feature/casino-holdem-wizard-polish
:feature/casino-quicksplit-side-pots
:feature/casino-holdem-rebuys
:feature/casino-holdem-rulings
:feature/casino-holdem-sidebar-polish
:feature/casino-holdem-keyboard
:feature/casino-holdem-action-undo
:feature/casino-holdem-pace
:feature/casino-holdem-side-pot-breakdown
:feature/casino-holdem-gestures
:feature/casino-holdem-card-picker
:feature/casino-holdem-live-betting
:feature/casino-holdem-bet-chips
:feature/casino-holdem-seat-legibility
:feature/casino-holdem-undo-toasts
:feature/casino-holdem-quick-split
:feature/casino-holdem-mobile-table
:feature/casino-holdem-hand-history
:feature/casino-texas-holdem
:feature/casino-holdem-dealer-mode-polish
:feature/fractional-learned-weights
:fix/stockfish-dispose-hang
:fix/blog-cache-staleness
:fix/workflows
:gitea/workflows
:echo-acoustic-ranging
:chess-ui-overhaul
:feature/customChessEngine
:feature/blog
:AddProject
:feature/generalUpdate
:tech-debt/chess-cleanup
:tests/CreatePlaywrightTests
:UpdateParticleSimulatorButton
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
A folded player's stack measured 2.22:1. Stacked on #80.
The contrast audit has been reporting clean for twenty rounds, and it never looked at these seats: the check skipped anything with opacity below 0.99 as "faded on purpose", and folded and sat-out seats faded their whole box — 0.5 and 0.58. Opacity on a box fades the text you still have to read along with the box you wanted to push back.
Measured off rendered pixels, 11.5px text, where AA asks 4.5:1:
A folded player's stack isn't decoration. It's what they'll have next hand and the answer to "how much has Ben got?", and at 2.22 it was barely there.
So the box recedes and the text doesn't — a flatter, darker background and a muted border, with name and stack colours that measure:
Taking the fade away took the signal with it
Which the screenshot showed and the numbers didn't: a sat-out seat became almost indistinguishable from a live one. A folded seat still says so twice — a red border and a line through the name — but sitting out had only faintness. It wears a dashed edge now, the same thing an empty chair wears, which is right: neither is in this hand, and the name and stack tell the two apart.
The same fault, found once the audit stopped hiding it
The key hints on the action bar are 9.6px and were measuring 2.97 to 3.33 against their buttons — a fade chosen for looks pushing text a dealer is meant to read under the threshold, exactly like the seats. They're 4.93 to 7.63 now, still quieter than the labels they sit beside.
And the audit no longer passes over faded text in silence. Something invisible is still exempt — there's nothing to read at zero opacity — but anything in between is reported as unmeasured, because a number nobody checked is not the same as a number that's fine. It now lists five: the four key caps and the disabled Export CSV button, which is disabled and therefore genuinely exempt.
Validation
269 tests still passing. Contrast offenders zero, layout audit clean, no console errors; the folded seat's red line-through and the sat-out seat's dashed edge both confirmed in cropped screenshots rather than assumed.
A folded player's stack measured 2.22:1. The contrast audit has been reporting clean for twenty rounds, and it never looked at these seats: the check skipped anything with opacity below 0.99 as "faded on purpose", and folded and sat-out seats faded their whole box -- 0.5 and 0.58. Opacity on a box fades the text you still have to read along with the box you wanted to push back. Measured off rendered pixels, 11.5px text, where AA asks 4.5:1: name stack live 13.28 4.75 folded 4.75 2.22 sitting out 7.00 3.22 A folded player's stack is not decoration. It is what they will have next hand and the answer to "how much has Ben got?", and at 2.22 it was barely there. So the box recedes and the text does not: a flatter, darker background and a muted border, with name and stack colours that measure. name stack live 13.28 4.75 (unchanged) folded 7.60 4.55 sitting out 7.60 4.71 Taking the fade away took the signal with it, which the screenshot showed and the numbers did not: a sat-out seat became almost indistinguishable from a live one. A folded seat still says so twice, with a red border and a line through the name, but sitting out had only faintness. It wears a dashed edge now -- the same thing an empty chair wears, which is right, because neither is in this hand, and the name and stack tell the two apart. The same fault, found once the audit stopped hiding it The key hints on the action bar are 9.6px and were measuring 2.97 to 3.33 against their buttons -- a fade chosen for looks pushing text a dealer is meant to read under the threshold, exactly like the seats. They are 4.93 to 7.63 now, still quieter than the labels they sit beside. And the audit no longer passes over faded text in silence. Something invisible is still exempt, since there is nothing to read at zero opacity, but anything in between is reported as unmeasured -- a number nobody checked is not the same as a number that is fine. It now lists five: the four key caps and the disabled Export CSV button, which is disabled and therefore genuinely exempt. 269 tests still passing. Contrast offenders zero, layout audit clean, no console errors; the folded seat's red line-through and the sat-out seat's dashed edge both confirmed in cropped screenshots rather than assumed. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgbPull request closed