Make the seats that are out of the hand readable again #81

Closed
jheaps wants to merge 1 commits from fix/casino-holdem-readable-dim-states into fix/casino-holdem-drop-broken-watermark
Owner

A folded player's stack measured 2.22:1. Stacked on #80.

The contrast audit has been reporting clean for twenty rounds, and it never looked at these seats: the check skipped anything with opacity below 0.99 as "faded on purpose", and folded and sat-out seats faded their whole box — 0.5 and 0.58. Opacity on a box fades the text you still have to read along with the box you wanted to push back.

Measured off rendered pixels, 11.5px text, where AA asks 4.5:1:

name stack
live 13.28 4.75
folded 4.75 2.22
sitting out 7.00 3.22

A folded player's stack isn't decoration. It's what they'll have next hand and the answer to "how much has Ben got?", and at 2.22 it was barely there.

So the box recedes and the text doesn't — a flatter, darker background and a muted border, with name and stack colours that measure:

name stack
live 13.28 4.75 (unchanged)
folded 7.60 4.55
sitting out 7.60 4.71

Taking the fade away took the signal with it

Which the screenshot showed and the numbers didn't: a sat-out seat became almost indistinguishable from a live one. A folded seat still says so twice — a red border and a line through the name — but sitting out had only faintness. It wears a dashed edge now, the same thing an empty chair wears, which is right: neither is in this hand, and the name and stack tell the two apart.

The same fault, found once the audit stopped hiding it

The key hints on the action bar are 9.6px and were measuring 2.97 to 3.33 against their buttons — a fade chosen for looks pushing text a dealer is meant to read under the threshold, exactly like the seats. They're 4.93 to 7.63 now, still quieter than the labels they sit beside.

And the audit no longer passes over faded text in silence. Something invisible is still exempt — there's nothing to read at zero opacity — but anything in between is reported as unmeasured, because a number nobody checked is not the same as a number that's fine. It now lists five: the four key caps and the disabled Export CSV button, which is disabled and therefore genuinely exempt.

Validation

269 tests still passing. Contrast offenders zero, layout audit clean, no console errors; the folded seat's red line-through and the sat-out seat's dashed edge both confirmed in cropped screenshots rather than assumed.

**A folded player's stack measured 2.22:1.** Stacked on #80. The contrast audit has been reporting clean for twenty rounds, and it never looked at these seats: the check skipped anything with opacity below 0.99 as "faded on purpose", and folded and sat-out seats faded their whole box — 0.5 and 0.58. Opacity on a box fades the text you still have to read along with the box you wanted to push back. Measured off rendered pixels, 11.5px text, where AA asks 4.5:1: | | name | stack | | --- | --- | --- | | live | 13.28 | 4.75 | | **folded** | 4.75 | **2.22** | | **sitting out** | 7.00 | **3.22** | A folded player's stack isn't decoration. It's what they'll have next hand and the answer to "how much has Ben got?", and at 2.22 it was barely there. So the box recedes and the text doesn't — a flatter, darker background and a muted border, with name and stack colours that measure: | | name | stack | | --- | --- | --- | | live | 13.28 | 4.75 *(unchanged)* | | folded | **7.60** | **4.55** | | sitting out | **7.60** | **4.71** | ## Taking the fade away took the signal with it Which the screenshot showed and the numbers didn't: a sat-out seat became almost indistinguishable from a live one. A folded seat still says so twice — a red border and a line through the name — but sitting out had only faintness. It wears a **dashed edge** now, the same thing an empty chair wears, which is right: neither is in this hand, and the name and stack tell the two apart. ## The same fault, found once the audit stopped hiding it The key hints on the action bar are 9.6px and were measuring **2.97 to 3.33** against their buttons — a fade chosen for looks pushing text a dealer is meant to read under the threshold, exactly like the seats. They're **4.93 to 7.63** now, still quieter than the labels they sit beside. And the audit no longer passes over faded text in silence. Something invisible is still exempt — there's nothing to read at zero opacity — but anything in between is reported as **unmeasured**, because a number nobody checked is not the same as a number that's fine. It now lists five: the four key caps and the disabled Export CSV button, which is disabled and therefore genuinely exempt. ## Validation 269 tests still passing. Contrast offenders zero, layout audit clean, no console errors; the folded seat's red line-through and the sat-out seat's dashed edge both confirmed in cropped screenshots rather than assumed.
jheaps added 1 commit 2026-09-01 19:10:33 -06:00
A folded player's stack measured 2.22:1.

The contrast audit has been reporting clean for twenty rounds, and it never looked at
these seats: the check skipped anything with opacity below 0.99 as "faded on purpose",
and folded and sat-out seats faded their whole box -- 0.5 and 0.58. Opacity on a box
fades the text you still have to read along with the box you wanted to push back.

Measured off rendered pixels, 11.5px text, where AA asks 4.5:1:

                  name    stack
  live            13.28   4.75
  folded           4.75   2.22
  sitting out      7.00   3.22

A folded player's stack is not decoration. It is what they will have next hand and the
answer to "how much has Ben got?", and at 2.22 it was barely there.

So the box recedes and the text does not: a flatter, darker background and a muted
border, with name and stack colours that measure.

                  name    stack
  live            13.28   4.75   (unchanged)
  folded           7.60   4.55
  sitting out      7.60   4.71

Taking the fade away took the signal with it, which the screenshot showed and the
numbers did not: a sat-out seat became almost indistinguishable from a live one. A
folded seat still says so twice, with a red border and a line through the name, but
sitting out had only faintness. It wears a dashed edge now -- the same thing an empty
chair wears, which is right, because neither is in this hand, and the name and stack
tell the two apart.

The same fault, found once the audit stopped hiding it

The key hints on the action bar are 9.6px and were measuring 2.97 to 3.33 against
their buttons -- a fade chosen for looks pushing text a dealer is meant to read under
the threshold, exactly like the seats. They are 4.93 to 7.63 now, still quieter than
the labels they sit beside.

And the audit no longer passes over faded text in silence. Something invisible is still
exempt, since there is nothing to read at zero opacity, but anything in between is
reported as unmeasured -- a number nobody checked is not the same as a number that is
fine. It now lists five: the four key caps and the disabled Export CSV button, which is
disabled and therefore genuinely exempt.

269 tests still passing. Contrast offenders zero, layout audit clean, no console
errors; the folded seat's red line-through and the sat-out seat's dashed edge both
confirmed in cropped screenshots rather than assumed.

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb
jheaps closed this pull request 2026-09-02 09:57:56 -06:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jheaps/JoshHeaps.Net#81