Stop the button's chip sitting on top of the name underneath it #115

Closed
jheaps wants to merge 1 commits from fix/casino-holdem-phone-look into fix/casino-holdem-sidebar-crowding
Owner

A phone screenshot, mid-hand, eight-handed: the seat with the button reads "Christop" and then a white D.

The name is centred across the whole puck and the chip sits in its top-right corner on a layer above, so a long name runs underneath and stops. Measured: "Christopher" lost 20px of its 64px box.

The bad part is the silence. The text believed it had the room it was being painted out of, so no ellipsis appeared — nothing on screen said the name went on. On the one seat at the table a dealer looks at most.

The name now keeps out of the chip's corner on the seat that has the button, so a long one ends in an ellipsis before it gets there. Only that seat: every other puck keeps its full width, because the chip on those is invisible.

And the audit has a check for it now

Nothing it had would have caught this. The occlusion check is about controls a thumb has to reach; this is a label a dealer has to read. The new check measures every seat's name against its own dealer chip and blind badges, and I undid the fix by hand to confirm it fires:

div.seatPuckName "Christopher" :: 20px under button.dealerChip.active "D"

Validated

  • Before: clipped: false, 20px covered. After: clipped: true (the ellipsis is doing its job), 0px covered.
  • 182 audits across 13 viewports, both input kinds, plain and straddled tables, every overlay: clean. The only notes are the disabled Export CSV button and the 44px rule standing itself down on a mouse.
  • Suite unchanged at 578, 0 failures — this round is CSS, one line of render, and the instrument.
A phone screenshot, mid-hand, eight-handed: the seat with the button reads **"Christop"** and then a white D. The name is centred across the whole puck and the chip sits in its top-right corner on a layer above, so a long name runs underneath and stops. Measured: **"Christopher" lost 20px of its 64px box**. The bad part is the silence. The text believed it had the room it was being painted out of, so **no ellipsis appeared** — nothing on screen said the name went on. On the one seat at the table a dealer looks at most. The name now keeps out of the chip's corner on the seat that has the button, so a long one ends in an ellipsis before it gets there. Only that seat: every other puck keeps its full width, because the chip on those is invisible. ### And the audit has a check for it now Nothing it had would have caught this. The occlusion check is about **controls a thumb has to reach**; this is a **label a dealer has to read**. The new check measures every seat's name against its own dealer chip and blind badges, and I undid the fix by hand to confirm it fires: > `div.seatPuckName "Christopher" :: 20px under button.dealerChip.active "D"` ### Validated - Before: `clipped: false`, 20px covered. After: `clipped: true` (the ellipsis is doing its job), 0px covered. - **182 audits** across 13 viewports, both input kinds, plain and straddled tables, every overlay: clean. The only notes are the disabled Export CSV button and the 44px rule standing itself down on a mouse. - Suite unchanged at **578, 0 failures** — this round is CSS, one line of render, and the instrument.
jheaps added 1 commit 2026-09-02 09:52:27 -06:00
A phone screenshot, mid-hand, eight-handed: the seat with the button reads
"Christop" and then a white D. The name is centred across the whole puck and the
chip sits in its top-right corner on a layer above, so a long name runs
underneath and stops — measured, "Christopher" lost 20px of its 64px box.

The bad part is the silence. The text believed it had the room it was being
painted out of, so no ellipsis appeared: nothing on screen said the name went on.
On the one seat at the table a dealer looks at most.

The name now keeps out of the chip's corner on the seat that has the button, so a
long one ends in an ellipsis before it gets there. Only that seat — every other
puck has its full width, because the chip on those is invisible.

And the audit has a check for it now. Nothing it had would have caught this: the
occlusion check is about controls a thumb has to reach, and this is a label a
dealer has to read. The new one measures every seat's name against its own chip
and badges, and the fix was undone by hand to confirm it fires — "20px under
button.dealerChip.active".

182 audits across 13 viewports, both input kinds, plain and straddled tables,
every overlay: clean.

Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb
jheaps closed this pull request 2026-09-02 09:58:10 -06:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jheaps/JoshHeaps.Net#115