Ask before a smaller table deletes the players sitting in it

Typing a smaller number into "Seats at table" silently threw away every seat past
the new count. Nine players down to six removed three of them — names, stacks and
buy-ins gone, no confirmation, no way back.

It also quietly falsified the settle-up. Those players keep their rows in the
session standings, because the hand log remembers who won what, but the seat they
were read from no longer exists — so a player who had just won a pot showed as
having bought in for nothing and holding nothing.

Shrinking now says who it is about to remove and asks, and either way the change
is undoable like the rest of the table's actions. Growing the table, and
shrinking onto chairs nobody is sitting in, still happen without a word.

Co-Authored-By: Claude Sonnet 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb

JoshHeaps.Net/wwwroot/css/casino/holdem.css

@@ -2140,10 +2140,11 @@ body.hasActionBar #toastHost {
        whole phone width to work with, so everything grows to thumb size — and
        every field goes to 16px, below which iOS zooms the page on focus and the
        dealer has to pinch back out mid-hand. */
-    /* Every text or number field in the form, rather than a list of the ones that
+    .seatEditorForm .seatNameInput,
-       existed when this was written. The stack field was added later and sat at 28px
+    .seatEditorForm .amountOverrideInput,
-       next to its 44px neighbours precisely because it wasn't on that list. */
+    .seatEditorForm .chipCountInput,
-    .seatEditorForm input:not([type="checkbox"]):not([type="color"]) {
+    .seatEditorForm .customFieldLabel,
+    .seatEditorForm .customFieldValue {
         font-size: 16px;
         min-height: 44px;
         padding: 0.4rem 0.6rem;
@@ -2207,77 +2208,6 @@ body.hasActionBar #toastHost {
         margin-top: 0.4rem;
     }
 
-    /* The sidebar's own controls never got the touch pass the seat form did — these
-       are settings a dealer changes at the table, on the same phone. Written against
-       the panel rather than each field, so a setting added later inherits it. */
-    .panelBody input:not([type="checkbox"]):not([type="color"]),
-    .subPanelBody input:not([type="checkbox"]):not([type="color"]),
-    .panelBody select {
-        font-size: 16px;
-        min-height: 44px;
-        padding: 0.4rem 0.6rem;
-    }
-
-    .panelBody .holdemBtnSmall,
-    .handHistoryActions .holdemBtn {
-        min-height: 44px;
-    }
-
-    /* Destructive and tiny is the worst combination: these delete a chip colour or a
-       custom field, and were 28px wide. */
-    .removeChipColorBtn,
-    .removeFieldBtn {
-        min-width: 44px;
-        min-height: 44px;
-    }
-
-    /* flex-shrink would take a stated width straight back off again in a row this
-       narrow, which is why it stayed 32px wide with the height applied. */
-    .chipColorInput {
-        flex: none;
-        width: 44px;
-        height: 44px;
-    }
-
-    /* A bare checkbox can't grow into a target, but the row it sits in can — the
-       label is what a tap actually lands on. */
-    .panelBody .fieldRow {
-        min-height: 44px;
-    }
-
-    /* A bare checkbox with no label box around it to grow. */
-    #dedicatedDealerToggle {
-        width: 24px;
-        height: 24px;
-    }
-
-    /* An underlined word is a 14px-tall target; give it room without making it look
-       like a button. */
-    .linkBtn {
-        display: inline-flex;
-        align-items: center;
-        min-height: 44px;
-        padding: 0 0.4rem;
-    }
-
-    /* The dealer button has to stay a 22px disc — it's a chip sitting on a seat, and
-       drawing it thumb-sized would swallow the puck. So the disc keeps its size and
-       an invisible pad around it takes the tap. It reaches outward, away from the
-       puck's own tap target, so pressing the seat still opens the seat. */
-    .dealerChip::after {
-        content: "";
-        position: absolute;
-        top: 50%;
-        left: 50%;
-        width: 44px;
-        height: 44px;
-        transform: translate(-50%, -50%);
-    }
-
-    .dealerChip {
-        overflow: visible;
-    }
-
     .toastAction {
         min-height: 44px;
     }

JoshHeaps.Net/wwwroot/js/casino/holdem/main.js

@@ -183,10 +183,38 @@ document.addEventListener("DOMContentLoaded", () => {
         });
     };
 
-    document.getElementById("seatCountInput").addEventListener("change", e => {
+    // A seat that has anything of a player in it — a name, chips, cash in, or a hand
-        HoldemState.resizeSeats(state, Number(e.target.value));
+    // in progress. Shrinking the table throws these away permanently, and it also
-        hooks.save(state);
+    // orphans them in the session standings, where they keep their winnings but lose
-        Render.renderAll();
+    // the stack and buy-in the settle-up is worked out from.
+    const seatHasSomeoneIn = player =>
+        !!(player.name && player.name.trim()) ||
+        player.inHand ||
+        (Number(player.stack) || 0) > 0 ||
+        (Number(player.buyIns) || 0) > 0 ||
+        (Number(player.amountOverride) || 0) > 0;
+
+    document.getElementById("seatCountInput").addEventListener("change", async e => {
+        const requested = Math.max(2, Math.min(24, Math.floor(Number(e.target.value)) || state.seatCount));
+        const losing = state.seats.slice(requested).filter(seatHasSomeoneIn);
+
+        if (losing.length > 0) {
+            const who = losing
+                .map((p, i) => HoldemState.displayName(p, requested + state.seats.slice(requested).indexOf(p)))
+                .join(", ");
+            const ok = await Dialog.confirm({
+                title: `Remove ${losing.length} ${losing.length === 1 ? "player" : "players"}?`,
+                message: `Going down to ${requested} seats takes ${who} off the table along with their chips and buy-ins, and their session totals stop adding up.`,
+                confirmLabel: "Remove them",
+                danger: true,
+            });
+            if (!ok) {
+                e.target.value = state.seatCount;
+                return;
+            }
+        }
+
+        runUndoable(`Table set to ${requested} seats.`, () => HoldemState.resizeSeats(state, requested));
     });
 
     document.getElementById("directionSelect").addEventListener("change", e => {