Time out Stockfish process exit so finished self-play games can't wedge in the store

DisposeAsync awaited WaitForExitAsync with no timeout; a Stockfish process that doesn't exit on "quit" blocked GameStore's removal task forever, leaving the finished game stuck in the store and cluttering the live-watch list indefinitely. Co-Authored-By: Claude Sonnet 5 <[email protected]> Claude-Session: https://claude.ai/code/session_018CmAti1baCjidbJM2HeJfk
2026-08-31 11:23:59 -06:00
parent 7562ded92a
commit 2f53c2f0ed
1 changed files with 16 additions and 1 deletions
@@ -100,11 +100,26 @@ public sealed class Stockfish : IChessEngine
            if (line == token) break;
    }

+    // If Stockfish doesn't exit on "quit" (crashed, zombie, ignores stdin close), don't hang
+    // here forever — that would block GameStore's removal task and leave the finished game
+    // stuck in the store, cluttering the watch page indefinitely.
+    private static readonly TimeSpan _exitTimeout = TimeSpan.FromSeconds(5);
+
    public async ValueTask DisposeAsync()
    {
        Send("quit");
        _stdin.Close();
-        await _p.WaitForExitAsync();
+
+        try
+        {
+            await _p.WaitForExitAsync().WaitAsync(_exitTimeout);
+        }
+        catch (TimeoutException)
+        {
+            if (!_p.HasExited)
+                _p.Kill(entireProcessTree: true);
+        }
+
        _p.Dispose();
    }
 }