jheapsandClaude Opus 5
db208a1a86
Seeded a table that looks like a real game — "Mike from work", "Jean-Philippe", stacks from $12 to $3,200,000 — and measured what the layout does with it. ".00" was costing a third of a seat puck Every amount rendered with two forced decimal places. Measured, the trailing ".00" is ~22px, against the 64px a seat puck has to show a stack in. So "$1,250,000.00" needed 102px of a 64px box — and because a number has no spaces to break on, it neither wrapped nor ellipsised. It drew straight out over the seat next to it. Money now shows cents only when there are cents. A chip game deals in whole numbers nearly all the time, and "$12" says exactly what "$12.00" said in half the width. A quarter-blind game is untouched: $0.25, $12.50 and $0.75 pots all still read as before, checked against a 25c/50c table. That alone took "$1,250,000.00" down to "$1,250,000" — 102px to 80px, still wider than the 64px puck. The remaining overflow is handled by stepping the font down on long amounts, which keeps every digit. Abbreviating to "$1.25M" would have fit more comfortably and was the obvious move, but a dealer reading a rounded stack off the felt is a worse failure than a small one, and the exact figure is the entire point of the tool. Measured after: every stack now paints inside its own puck, nothing spills onto a neighbour. Because Money.format is the single formatter all 47 call sites go through, this lands on the seat pucks, action bar, pot breakdown, seat menu, standings and history at once — the payoff from consolidating it earlier. The CSV export couldn't be added up The file exists so a house manager or a disputed chip count has something that outlives the tab, and every money column in it was written as text: "$1,250,000.00". The commas were quoted correctly so the file always parsed — it just imported as strings, so the one thing anyone opens it to do, total a column, needed every cell cleaned first. Money columns now go in as bare numbers (1250000.00) with no symbol and no separators. The columns meant for humans stay human: names are still names, payouts still read "Alexandra: $1,250,000", and a name with a comma in it is still quoted. 12 new tests (88 total, all passing), including the case that would be ruined by dropping cents unconditionally, and a proper quote-aware CSV parser to check every money cell parses as a number. Re-ran the occlusion sweep from the previous round at 9 seats, 10 seats and tournament stacks: still clean, no regression from the font changes. Co-Authored-By: Claude Opus 5 <[email protected]> Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb
64 lines
2.5 KiB
JavaScript
64 lines
2.5 KiB
JavaScript
// Shared money handling for every casino surface. Kept apart from the table's
|
|
// rendering so the quick-split calculator can pull it in without dragging the whole
|
|
// seat/chip UI along with it.
|
|
//
|
|
// Everything the dealer touches is money, and money is decimal, so every module used
|
|
// to carry its own `Math.round(x * 100) / 100`. That's one rounding rule written out
|
|
// sixteen times in six files, which is sixteen chances for one of them to drift.
|
|
// It lives here now, and the modules that do arithmetic call these instead.
|
|
const Money = {
|
|
// Half a cent. Chip comparisons need a tolerance: a stack that lands on
|
|
// 0.0000000001 after a split is empty as far as a dealer is concerned, and an
|
|
// exact `> 0` would treat that player as still having chips to bet.
|
|
EPSILON: 0.004,
|
|
|
|
// All money maths goes through cents, so 0.1 + 0.2 never reaches a payout.
|
|
toCents(amount) {
|
|
return Math.round((Number(amount) || 0) * 100);
|
|
},
|
|
|
|
fromCents(cents) {
|
|
return cents / 100;
|
|
},
|
|
|
|
round(amount) {
|
|
return this.toCents(amount) / 100;
|
|
},
|
|
|
|
// Cents only when there are cents.
|
|
//
|
|
// A chip game deals in whole numbers nearly all the time, and a trailing ".00"
|
|
// is two characters that say nothing — measured at ~22px, against the 64px a
|
|
// seat puck has to show a stack in. "$1,250,000.00" doesn't fit and wraps;
|
|
// "$1,250,000" does. Amounts that genuinely carry cents still show them, so a
|
|
// 25c-blind game reads exactly as it did.
|
|
format(amount) {
|
|
const value = Number(amount) || 0;
|
|
const hasCents = this.toCents(value) % 100 !== 0;
|
|
return `$${value.toLocaleString(undefined, {
|
|
minimumFractionDigits: hasCents ? 2 : 0,
|
|
maximumFractionDigits: 2,
|
|
})}`;
|
|
},
|
|
|
|
// The same amount for a spreadsheet rather than for a person: no currency symbol
|
|
// and no thousands separators, because those are what make a column of money
|
|
// import as text and refuse to add up.
|
|
forSheet(amount) {
|
|
return (this.toCents(amount) / 100).toFixed(2);
|
|
},
|
|
|
|
// "+$40.00" / "-$40.00" rather than "$-40.00" — a standings column is read at a
|
|
// glance, and the sign belongs out front where the eye lands first.
|
|
formatSigned(amount) {
|
|
const value = Number(amount) || 0;
|
|
if (value > 0) return `+${this.format(value)}`;
|
|
if (value < 0) return `-${this.format(Math.abs(value))}`;
|
|
return this.format(0);
|
|
},
|
|
};
|
|
|
|
if (typeof module !== "undefined" && module.exports) {
|
|
module.exports = Money;
|
|
}
|