jheapsandClaude Opus 5
3fe16fa7f2
The hint under the table has said this on every screen since the gestures went in:
Tap a seat to edit - double-tap to fold - press and hold for quick actions -
drag to swap seats.
Three of those work on a phone. The fourth never has. Swapping seats is HTML5
drag-and-drop -- draggable="true", dragstart, drop -- and a touch screen does not
generate drag events at all. So the one clause written in the same breath as "tap"
and "press and hold" was the one thing a thumb could never do.
I found it by dragging seat 1 onto seat 4 with real touch pointer events and watching
nothing happen: no swap, no menu, no error.
Moving a seat is in the long-press menu now, which is the route a thumb already takes
for everything else. "Move to..." replaces the action list with the other chairs, by
number and name, and picking one makes the move:
Move Ben to...
Their chips, cards and bet go with them. The button and the blinds stay on the chair.
Seat 1 - Ann Seat 3 - Cal Seat 4 - Dee Seat 5 - empty ...
That subtitle is the rule, and it is the one a card room uses: the whole seat travels,
while everything naming a position stays put. Somebody who sits down in the big
blind's chair is the big blind.
Driven through on a phone: Ben, small blind, $109 behind with $1 posted, moves to
seat 5 with both numbers; seat 2 goes empty; the button stays on seat 1; the toast
reads "Ben moved to seat 5" and undo puts it all back. Reopening the menu on another
seat shows actions again rather than the chair list it closed on.
The hint tells the truth per device now -- dragging is only mentioned where a mouse
exists. Dragging still works there, checked.
8 tests (232 total): the whole seat moves, the bet moves with it, chips are conserved,
the button and the blinds stay on their chairs, swapping twice is a no-op, and a chair
that is not there is refused rather than swallowed.
One audit fix rides along. The "one dealer button" check counted the empty slot that a
hovered seat deliberately fades in, so it reported two buttons whenever a mouse
happened to rest on the table -- which is most of the time a mouse exists. It ignores
the hovered seat now, and still catches the real fault: with the pre-#62 behaviour put
back it reports six, or five while hovering.
Co-Authored-By: Claude Opus 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_015bnp7xKUPFFSpwkYNFaPgb
96 lines
3.4 KiB
JavaScript
96 lines
3.4 KiB
JavaScript
// Two players changing chairs.
|
|
const test = require("node:test");
|
|
const assert = require("node:assert");
|
|
const { Betting, HoldemState, makeTable, chipsOnTable } = require("./load");
|
|
|
|
test("the whole seat moves", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1, 2], stack: 100 });
|
|
state.seats[0].name = "Ann";
|
|
state.seats[0].cards = ["AS", "KD"];
|
|
state.seats[0].stack = 175;
|
|
state.seats[4].name = "";
|
|
|
|
HoldemState.swapSeats(state, 0, 4);
|
|
|
|
assert.equal(state.seats[4].name, "Ann");
|
|
assert.deepEqual(state.seats[4].cards, ["AS", "KD"]);
|
|
assert.equal(state.seats[4].stack, 175);
|
|
assert.equal(state.seats[0].name, "");
|
|
});
|
|
|
|
test("what they have in the pot goes with them", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1, 2], stack: 100 });
|
|
Betting.beginHand(state);
|
|
const posted = state.seats.map(p => p.committed);
|
|
const before = chipsOnTable(state);
|
|
|
|
HoldemState.swapSeats(state, 1, 4);
|
|
|
|
assert.equal(state.seats[4].committed, posted[1]);
|
|
assert.equal(state.seats[1].committed, posted[4]);
|
|
assert.equal(chipsOnTable(state), before, "a swap never creates or destroys a chip");
|
|
});
|
|
|
|
test("the button stays on the chair, not on the player", () => {
|
|
// A card room moves the button around the table, not around the people. Somebody
|
|
// who sits down in the big blind's chair is the big blind.
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1, 2], stack: 100, dealerSeatIndex: 0 });
|
|
state.seats[0].name = "Ann";
|
|
|
|
HoldemState.swapSeats(state, 0, 2);
|
|
|
|
assert.equal(state.dealerSeatIndex, 0);
|
|
assert.notEqual(state.seats[0].name, "Ann");
|
|
});
|
|
|
|
test("the blinds follow the chairs too", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1, 2, 3], stack: 100, dealerSeatIndex: 0 });
|
|
Betting.beginHand(state);
|
|
const before = HoldemState.getBlindSeats(state);
|
|
|
|
HoldemState.swapSeats(state, before.sbIndex, before.bbIndex);
|
|
const after = HoldemState.getBlindSeats(state);
|
|
|
|
assert.equal(after.sbIndex, before.sbIndex);
|
|
assert.equal(after.bbIndex, before.bbIndex);
|
|
});
|
|
|
|
test("swapping a seat with itself does nothing and says so", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1], stack: 100 });
|
|
const before = JSON.stringify(state);
|
|
|
|
assert.equal(HoldemState.swapSeats(state, 1, 1), false);
|
|
assert.equal(JSON.stringify(state), before);
|
|
});
|
|
|
|
test("a chair that isn't there is refused rather than swallowed", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1], stack: 100 });
|
|
const before = JSON.stringify(state);
|
|
|
|
assert.equal(HoldemState.swapSeats(state, 0, 99), false);
|
|
assert.equal(HoldemState.swapSeats(state, -1, 0), false);
|
|
assert.equal(JSON.stringify(state), before);
|
|
});
|
|
|
|
test("swapping twice puts everything back", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1, 2, 3], stack: 100 });
|
|
Betting.beginHand(state);
|
|
const before = JSON.stringify(state);
|
|
|
|
HoldemState.swapSeats(state, 1, 3);
|
|
HoldemState.swapSeats(state, 1, 3);
|
|
|
|
assert.equal(JSON.stringify(state), before);
|
|
});
|
|
|
|
test("moving into an empty chair leaves an empty chair behind", () => {
|
|
const state = makeTable({ seatCount: 6, seated: [0, 1], stack: 100 });
|
|
state.seats[1].name = "Ben";
|
|
|
|
HoldemState.swapSeats(state, 1, 5);
|
|
|
|
assert.equal(state.seats[5].name, "Ben");
|
|
assert.equal(state.seats[5].inHand, true);
|
|
assert.equal(state.seats[1].inHand, false);
|
|
});
|